add support for spring boot 4, with a fallback to 3#1226
add support for spring boot 4, with a fallback to 3#1226ramonskie merged 1 commit intocloudfoundry:mainfrom
Conversation
|
|
32072db to
ad838f3
Compare
|
why is a fallback necessary? |
|
@ramonskie I think calls to SpringBoot deps change when going from SpringBoot 3 -> 4, so you I guess you run into runtime "class not found" exceptions: e.g. pivotal-cf/java-cfenv@1dd9ccb |
|
@ramonskie the compatibility matrix also mentions that java-cfenv 4.x is for Spring Boot 4 and java-cfenv 3.x is for Spring Boot 3 |
|
cfenv should be added as a dependency-build and not be added within here in the manifest. we should add something like there in the config.yml im putting this here in the hope that ppl will understand the structure more clearly and that they could make a pr for this :) |
Thanks! I'll prep a PR |
ad838f3 to
eb9a18d
Compare
eb9a18d to
1d030d7
Compare
stokpop
left a comment
There was a problem hiding this comment.
Check default version for SB3.
1d030d7 to
779c8af
Compare
|
i do not like the hardcoded defaults. but for now it is okay is i do not expect it to change anytime soon |
|
@ramonskie thanks for the support and merging the pr! |
related to #1222